Oidc password authentication on uninitialized Oidc fix#36671
Merged
Conversation
SangJunBak
requested review from
a team,
Alphadelta14 and
leedqin
and removed request for
a team and
Alphadelta14
SangJunBak
changed the title
SangJunBak
force-pushed
the
jun/-fix-console
branch
from
70c49e0 to
bb1b042
Compare
Contributor
Author
|
I feel like a follow up to this is an e2e test framework that:
Then perhaps using frontegg-mock, we could do something similar for oidc. |
SangJunBak
force-pushed
the
jun/-fix-console
branch
2 times, most recently
from
155e5b9 to
d2890ab
Compare
Before we were getting throws on password login when Oidc was never initialized. This allows us to not have to check if the oidcManager is available everytime we want Oidc auth details.
SangJunBak
force-pushed
the
jun/-fix-console
branch
from
d2890ab to
ef864c1
Compare
leedqin
reviewed
May 21, 2026
| enabled: isOidc, | ||
| staleTime: Infinity, | ||
| retry: false, | ||
| retryOnMount: false, // Do not retry on mount, otherwise we will retry indefinitely |
Contributor
There was a problem hiding this comment.
this is cool! Didn't know retryOnMount was a thing
SangJunBak
force-pushed
the
jun/-fix-console
branch
2 times, most recently
from
c8e1d69 to
da708c0
Compare
leedqin
reviewed
May 21, 2026
| } | ||
| const oidcAuthErrorMessage = auth?.error?.message ?? null; | ||
|
|
||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
Suggested change
| useEffect(() => { | |
| const oidcError = auth.error?.message? ?? null; | |
| const displayError = | |
| error || | |
| (oidcAuthErrorMessage && | |
| `${oidcAuthErrorMessage}. It looks like there may be an issue with the sign-in configuration. Please review your OIDC settings or check the console logs for more information.`) || | |
| null; | |
| return ( | |
| <VStack spacing="2" alignItems="center"> | |
| {displayError&& <Alert variant="error" minWidth="100%" message={error} />} |
Contributor
There was a problem hiding this comment.
I imagine this flow should work
- . App mounts →
auth.error = null→oidcError = undefined→displayError = null→ no Alert. react-oidc-contextpopulatesauth.error→ AuthProvider re-renders consumers.SsoLoginLinkre-renders →oidcErroris recomputed fromauth.error.message→displayErroris the friendly message → Alert appears.- User clicks SSO →
handleSsoLoginruns → ifsigninRedirect()rejects,setError(...)runs → next render,error(local) wins via||short-circuit → Alert swaps to that message. - Issuer is fixed and the user reloads →
auth.errorclears →displayError = null→ Alert disappears.
Contributor
Author
There was a problem hiding this comment.
Makes sense to me!
SangJunBak
force-pushed
the
jun/-fix-console
branch
from
da708c0 to
d304f41
Compare
SangJunBak
force-pushed
the
jun/-fix-console
branch
from
d304f41 to
26065b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we were getting throws on password login when Oidc was never initialized. This allows us to not have to check if the oidcManager is available everytime we want Oidc auth details.
Motivation
Bug found during product review when logging in as mz_system before Oidc was configured
Verification
Run locally against Oidc instance and login as mz_system. Before you would crash because we were trying to access properties in useAuth that didn't exist. Now it doesn't crash